[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/pflash_cfi0[12]: Use host-uti
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/pflash_cfi0[12]: Use host-utils.h ctz32() |
|
Date: |
Wed, 19 Sep 2012 09:01:36 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Peter Maydell <address@hidden> writes:
> On 18 September 2012 17:53, Stefan Weil <address@hidden> wrote:
>> What about moving the ctz32 function (or even all of host-utils.h) to
>> bitops.h?
>
> I guess that would make some sense, though I'm not generally
> a huge fan of shuffling code around.
>
> (bitops.h and host-utils.h are not under the same license terms,
> which might complicate things slightly.)
Have a look at hw/hd-geometry.c for a suitable boilerplate comment.