Re: [Qemu-trivial] [Qemu-devel] [PATCH] pflash: Avoid warnings from coverity

[Peter Maydell]

On 22 September 2012 17:29, Stefan Hajnoczi <address@hidden> wrote:
> Please report the errno and possibly bdrv_get_device_name() to uniquely
> identify this block device.
>
> Peter's comments about reporting errors to the guest make sense to me.
> I'm not sure how much work that involves, printing the error is a step
> in the right direction but we shouldn't forget the TODO.

I don't think printing errors to stderr at this layer is the right
thing to do at all. You can make a case for "print nothing and let
the guest handle it", and also for "log errors in the block layer"
(which would make all block device users consistent and mean we
only needed one bit of code for this rather than lots), but I don't
see a case for printing errors in the middle of the stack like this.

(I am also somewhat reluctant to add further random fprintfs without
instituting a proper controllable logging mechanism first.)

-- PMM