qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-mips: Clean up microMIPS3


From: Aurelien Jarno
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode
Date: Thu, 15 Nov 2012 15:04:24 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Nov 15, 2012 at 02:34:31AM +0000, Johnson, Eric wrote:
> Hi Chen,
> 
> Please only remove the POOL48A opcode.
> 
> The others are documented in the microMIPS64 Instruction Set manual ( 
> http://www.mips.com/secure-download/index.dot?product_name=/auth/MD00087-2B-MIPS64BIS-AFP-03.51.pdf
>  ).  See http://www.mips.com/products/architectures/mips64/ for other 
> relavent docs.
> 
> Instead of removing them please surround the POOL32S, DADDIU32, SD32, and 
> LD32 opcodes with
> #if defined(TARGET_MIPS64)
> 

I don't think a #if is necessary there, this makes the code more
difficult to read, while it doesn't change anything on the generated
code.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net



reply via email to

[Prev in Thread] Current Thread [Next in Thread]