qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] Possible wrong microMIPS opcode encoding


From: Wei-Ren Chen
Subject: Re: [Qemu-trivial] [PATCH] Possible wrong microMIPS opcode encoding
Date: Fri, 16 Nov 2012 09:26:40 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Nov 15, 2012 at 02:53:38PM +0100, Aurelien Jarno wrote:
> On Thu, Nov 15, 2012 at 07:57:04AM +0800, 陳韋任 (Wei-Ren Chen) wrote:
> > On Wed, Nov 14, 2012 at 05:45:21PM +0100, Aurelien Jarno wrote:
> > > On Wed, Nov 14, 2012 at 10:49:55AM +0800, 陳韋任 (Wei-Ren Chen) wrote:
> > > > Hi all,
> > > > 
> > > >   While reading microMIPS decoding, I found a possible wrong opcode
> > > > encoding. According to [1] page 337, the bits 13..12 for MULTU is
> > > > 0x01 rather than 0x00. Please review, thanks.
> > > > 
> > > > [1] MIPS Architecture for Programmers VolumeIV-e: The MIPS DSP
> > > >     Application-Specific Extension to the microMIPS32 Architecture
> > > 
> > > This is indeed correct, but I guess the page you meant is 166. Page 337
> > > refers to the original MULTU instruction from the MIPS Architecture for
> > > Programmers Volume II-B: The microMIPS32 Instruction Set.
> > > 
> > > On the other the microMIPS32 encoding for DSP instruction is not yet
> > > supported.
> > 
> >   Maybe we can start cleanup it a little bit. ;) Is this OK to commit?
> > 
> 
> My point was that the patch what correct, but not the comment. I have
> committed it after fixing the comment.

  I saw your commit, thanks. btw, I found codesourcery MIPS GCC has a
option called "-mmicromips". Would you mind confirm this option does
work for me?

Regards,
chenwj
 
-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj



reply via email to

[Prev in Thread] Current Thread [Next in Thread]