[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2 06/11] virtfs-proxy-helper: Fix unchecked s
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [PATCH v2 06/11] virtfs-proxy-helper: Fix unchecked strdup() by conv. to g_strdup() |
Date: |
Thu, 17 Jan 2013 12:22:15 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 16, 2013 at 06:32:15PM +0100, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> fsdev/virtfs-proxy-helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index 6b9afd3..36f6616 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -1039,7 +1039,7 @@ int main(int argc, char **argv)
> }
> switch (c) {
> case 'p':
> - rpath = strdup(optarg);
> + rpath = g_strdup(optarg);
> break;
> case 'n':
> is_daemon = false;
> @@ -1048,7 +1048,7 @@ int main(int argc, char **argv)
> sock = atoi(optarg);
> break;
> case 's':
> - sock_name = strdup(optarg);
> + sock_name = g_strdup(optarg);
rpath and sock_name are leaked. Not important though because they are
in main().
Stefan
- [Qemu-trivial] [PATCH v2 05/11] spice: Fix unchecked strdup() by converting to g_strdup(), (continued)
- [Qemu-trivial] [PATCH v2 05/11] spice: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH v2 04/11] readline: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH v2 09/11] libcacard: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH v2 01/11] g_malloc(0) and g_malloc0(0) return NULL; simplify, Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH v2 10/11] qapi: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH v2 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename(), Markus Armbruster, 2013/01/16
- [Qemu-trivial] [PATCH v2 06/11] virtfs-proxy-helper: Fix unchecked strdup() by conv. to g_strdup(), Markus Armbruster, 2013/01/16
- Re: [Qemu-trivial] [PATCH v2 06/11] virtfs-proxy-helper: Fix unchecked strdup() by conv. to g_strdup(),
Stefan Hajnoczi <=
- [Qemu-trivial] [PATCH v2 02/11] g_strdup(NULL) returns NULL; simplify, Markus Armbruster, 2013/01/16