[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 10/11] qapi: Fix unchecked str
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 10/11] qapi: Fix unchecked strdup() by converting to g_strdup() |
Date: |
Tue, 22 Jan 2013 14:38:43 -0200 |
On Tue, 22 Jan 2013 11:08:05 +0100
Markus Armbruster <address@hidden> wrote:
> Note that we already free with g_free().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
> ---
> qapi/qmp-registry.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/qmp-registry.c b/qapi/qmp-registry.c
> index 70cdbca..28bbbe8 100644
> --- a/qapi/qmp-registry.c
> +++ b/qapi/qmp-registry.c
> @@ -92,7 +92,7 @@ char **qmp_get_command_list(void)
> list_head = list = g_malloc0(count * sizeof(char *));
>
> QTAILQ_FOREACH(cmd, &qmp_commands, node) {
> - *list = strdup(cmd->name);
> + *list = g_strdup(cmd->name);
> list++;
> }
>
- [Qemu-trivial] [PATCH v3 00/11] Trivial memory allocation fixes & cleanups, Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 05/11] spice: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 06/11] virtfs-proxy-helper: Fix unchecked strdup() by conv. to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 10/11] qapi: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 10/11] qapi: Fix unchecked strdup() by converting to g_strdup(),
Luiz Capitulino <=
- [Qemu-trivial] [PATCH v3 02/11] g_strdup(NULL) returns NULL; simplify, Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 09/11] libcacard: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 01/11] g_malloc(0) and g_malloc0(0) return NULL; simplify, Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 04/11] readline: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 03/11] hw/9pfs: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 11/11] qemu-ga: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 07/11] qemu-log: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- Re: [Qemu-trivial] [PATCH v3 00/11] Trivial memory allocation fixes & cleanups, Stefan Hajnoczi, 2013/01/22