qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 10/11] qapi: Fix unchecked str


From: Luiz Capitulino
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 10/11] qapi: Fix unchecked strdup() by converting to g_strdup()
Date: Tue, 22 Jan 2013 14:38:43 -0200

On Tue, 22 Jan 2013 11:08:05 +0100
Markus Armbruster <address@hidden> wrote:

> Note that we already free with g_free().
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Reviewed-by: Luiz Capitulino <address@hidden>

> ---
>  qapi/qmp-registry.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qapi/qmp-registry.c b/qapi/qmp-registry.c
> index 70cdbca..28bbbe8 100644
> --- a/qapi/qmp-registry.c
> +++ b/qapi/qmp-registry.c
> @@ -92,7 +92,7 @@ char **qmp_get_command_list(void)
>      list_head = list = g_malloc0(count * sizeof(char *));
>  
>      QTAILQ_FOREACH(cmd, &qmp_commands, node) {
> -        *list = strdup(cmd->name);
> +        *list = g_strdup(cmd->name);
>          list++;
>      }
>  




reply via email to

[Prev in Thread] Current Thread [Next in Thread]