[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 11/11] qemu-ga: Fix unchecked
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 11/11] qemu-ga: Fix unchecked strdup() by converting to g_strdup() |
Date: |
Tue, 22 Jan 2013 14:54:21 -0200 |
On Tue, 22 Jan 2013 11:08:06 +0100
Markus Armbruster <address@hidden> wrote:
> I figure it's freed somewhere deep down in QAPI, with g_free().
It is, by qapi_dealloc_type_str().
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
> ---
> qga/commands.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/commands.c b/qga/commands.c
> index 7ffb35e..528b082 100644
> --- a/qga/commands.c
> +++ b/qga/commands.c
> @@ -61,7 +61,7 @@ struct GuestAgentInfo *qmp_guest_info(Error **err)
>
> while (*cmd_list) {
> cmd_info = g_malloc0(sizeof(GuestAgentCommandInfo));
> - cmd_info->name = strdup(*cmd_list);
> + cmd_info->name = g_strdup(*cmd_list);
> cmd_info->enabled = qmp_command_is_enabled(cmd_info->name);
>
> cmd_info_list = g_malloc0(sizeof(GuestAgentCommandInfoList));
- [Qemu-trivial] [PATCH v3 06/11] virtfs-proxy-helper: Fix unchecked strdup() by conv. to g_strdup(), (continued)
- [Qemu-trivial] [PATCH v3 06/11] virtfs-proxy-helper: Fix unchecked strdup() by conv. to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 10/11] qapi: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 02/11] g_strdup(NULL) returns NULL; simplify, Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 09/11] libcacard: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 01/11] g_malloc(0) and g_malloc0(0) return NULL; simplify, Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 04/11] readline: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 03/11] hw/9pfs: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- [Qemu-trivial] [PATCH v3 11/11] qemu-ga: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 11/11] qemu-ga: Fix unchecked strdup() by converting to g_strdup(),
Luiz Capitulino <=
- [Qemu-trivial] [PATCH v3 07/11] qemu-log: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/22
- Re: [Qemu-trivial] [PATCH v3 00/11] Trivial memory allocation fixes & cleanups, Stefan Hajnoczi, 2013/01/22