[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial: Fix debug format strings
From: |
Andreas Färber |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial: Fix debug format strings |
Date: |
Tue, 19 Mar 2013 14:29:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 |
Am 19.03.2013 12:25, schrieb Kevin Wolf:
> This fixes the build of hw/serial.c with DEBUG_SERIAL enabled.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> hw/serial.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/serial.c b/hw/serial.c
> index 48a5eb6..0ccc499 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -306,7 +306,7 @@ static void serial_ioport_write(void *opaque, hwaddr
> addr, uint64_t val,
> SerialState *s = opaque;
>
> addr &= 7;
> - DPRINTF("write addr=0x%02x val=0x%02x\n", addr, val);
> + DPRINTF("write addr=0x%" HWADDR_PRIx " val=0x%" PRIx64 "\n", addr, val);
Are you intentionally dropping 02 in both places? That changes output FWIW.
Andreas
> switch(addr) {
> default:
> case 0:
> @@ -527,7 +527,7 @@ static uint64_t serial_ioport_read(void *opaque, hwaddr
> addr, unsigned size)
> ret = s->scr;
> break;
> }
> - DPRINTF("read addr=0x%02x val=0x%02x\n", addr, ret);
> + DPRINTF("read addr=0x%" HWADDR_PRIx " val=0x%02x\n", addr, ret);
> return ret;
> }
>
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg