qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] configure: Detect --disable-system and --targ


From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [PATCH] configure: Detect --disable-system and --target-list conflicts.
Date: Fri, 12 Apr 2013 13:15:50 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Sun, Apr 07, 2013 at 03:20:44PM +1000, Ben Leslie wrote:
> The user should not be allowed to configure a softmmu target
> when --disable-system is selected.
> 
> Signed-off-by: Ben Leslie <address@hidden>
> ---
>  configure | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index d685275..e4288ed 100755
> --- a/configure
> +++ b/configure
> @@ -1353,7 +1353,13 @@ else
>  fi
>  # see if system emulation was really requested
>  case " $target_list " in
> -  *"-softmmu "*) softmmu=yes
> +  *"-softmmu "*)
> +    if test "$softmmu" = "no"; then
> +      echo "ERROR: System emulation disabled (via --disable-system),
> however a "
> +      echo "       system emulation target specified in --target-list."
> +      exit 1
> +    fi
> +    softmmu=yes

Please use the new error_exit function.  Fine otherwise.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]