Re: [Qemu-trivial] [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line

[Anthony Liguori]

Paolo Bonzini <address@hidden> writes:

> Il 20/05/2013 18:21, Peter Maydell ha scritto:
>> Reformat the qapi-schema TargetType enumeration so that it has just
>> one target architecture name per line. This allows patches for
>> adding new targets to just add a single line, rather than having
>> to reformat most of the list (resulting in a hard-to-check diff).
>> 
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> d15a9c23 is an example of what you get otherwise.
>> 
>> I would much prefer it if we autogenerated this list so you didn't
>> need to change this file at all to add a new target, but Anthony
>> is against that; so this is at least an improvement.
>
> I have queued a patch for 1.6 that would change this field to a free
> string.  There is no use of this enum, not even for introspection.

I don't object to this, however..

> You
> don't need to know what targets were supported in the version that you
> compiled from.  Only one target is supported in this executable
> anyway.

It seems useful to me.  One day we may support multiple targets per
executable.

There's no obvious place where all of the possible targets are listed so
from the point of view of someone trying to figure out what the
platforms are while writing a management tool, it seems like a useful
thing to have.

We don't add targets very often...  are we optimizing for an uncommon
scenario here?

Regards,

Anthony Liguori

>
> Paolo
>
>>  qapi-schema.json |   30 ++++++++++++++++++++++++++----
>>  1 file changed, 26 insertions(+), 4 deletions(-)
>> 
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 199744a..a8d361e 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -3018,10 +3018,32 @@
>>  # Since: 1.2.0
>>  ##
>>  { 'enum': 'TargetType',
>> -  'data': [ 'alpha', 'arm', 'cris', 'i386', 'lm32', 'm68k', 'microblazeel',
>> -            'microblaze', 'mips64el', 'mips64', 'mipsel', 'mips', 'moxie',
>> -            'or32', 'ppc64', 'ppcemb', 'ppc', 's390x', 'sh4eb', 'sh4',
>> -            'sparc64', 'sparc', 'unicore32', 'x86_64', 'xtensaeb', 'xtensa' 
>> ] }
>> +  'data': [ 'alpha',
>> +            'arm',
>> +            'cris',
>> +            'i386',
>> +            'lm32',
>> +            'm68k',
>> +            'microblazeel',
>> +            'microblaze',
>> +            'mips64el',
>> +            'mips64',
>> +            'mipsel',
>> +            'mips',
>> +            'moxie',
>> +            'or32',
>> +            'ppc64',
>> +            'ppcemb',
>> +            'ppc',
>> +            's390x',
>> +            'sh4eb',
>> +            'sh4',
>> +            'sparc64',
>> +            'sparc',
>> +            'unicore32',
>> +            'x86_64',
>> +            'xtensaeb',
>> +            'xtensa' ] }
>>  
>>  ##
>>  # @TargetInfo:
>>