[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug mes
From: |
Andreas Färber |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH][v4 2/3] debugcon: make debug message more readable |
Date: |
Thu, 23 May 2013 15:06:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Am 23.05.2013 08:58, schrieb liguang:
> before change:
> Bdebugcon: write addr=0x0000 val=0x6f
> odebugcon: write addr=0x0000 val=0x6f
> odebugcon: write addr=0x0000 val=0x74
> tdebugcon: write addr=0x0000 val=0x69
> idebugcon: write addr=0x0000 val=0x6e
> ndebugcon: write addr=0x0000 val=0x67
> gdebugcon: write addr=0x0000 val=0x20
> debugcon: write addr=0x0000 val=0x66
>
> after change:
> B [debugcon: write addr=0x0000 val=0x6f]
> o [debugcon: write addr=0x0000 val=0x6f]
> o [debugcon: write addr=0x0000 val=0x74]
> t [debugcon: write addr=0x0000 val=0x69]
> i [debugcon: write addr=0x0000 val=0x6e]
> n [debugcon: write addr=0x0000 val=0x67]
> g [debugcon: write addr=0x0000 val=0x20]
> [debugcon: write addr=0x0000 val=0x66]
>
> Signed-off-by: liguang <address@hidden>
> ---
> hw/char/debugcon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
> index 7e41c90..52fa0ab 100644
> --- a/hw/char/debugcon.c
> +++ b/hw/char/debugcon.c
> @@ -55,7 +55,7 @@ static void debugcon_ioport_write(void *opaque, hwaddr
> addr, uint64_t val,
> unsigned char ch = val;
>
> #ifdef DEBUG_DEBUGCON
> - printf("debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x\n", addr,
> val);
> + printf(" [debugcon: write addr=0x%04" HWADDR_PRIx " val=0x%02x]\n",
> addr, val);
While not wrong, this is rather exotic - wouldn't it be better to
fprintf() to stderr instead or to use qemu_log() or tracepoints?
Andreas
> #endif
>
> qemu_chr_fe_write(s->chr, &ch, 1);
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg