qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH trivial] slirp: cleanup leftovers from misc.h


From: Jan Kiszka
Subject: Re: [Qemu-trivial] [PATCH trivial] slirp: cleanup leftovers from misc.h
Date: Wed, 29 May 2013 15:59:58 +0900
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2013-05-28 05:51, Michael Tokarev wrote:
> There are quite a few leftover declarations in slirp/misc.h.
> Remove them.
> 
> Signed-off-by: Michael Tokarev <address@hidden>
> ---
>  slirp/misc.h |   14 --------------
>  1 file changed, 14 deletions(-)
> 
> I'm not entirely sure we should do this, since this kind of
> changes just moves us more and more away from the upstream, but...

AFAIK, there is no upstream worth tracking, so this is fine.

Jan

> 
> diff --git a/slirp/misc.h b/slirp/misc.h
> index cc36aeb..ba8beb1 100644
> --- a/slirp/misc.h
> +++ b/slirp/misc.h
> @@ -20,8 +20,6 @@ struct ex_list {
>  char *strdup(const char *);
>  #endif
>  
> -void do_wait(int);
> -
>  #define EMU_NONE 0x0
>  
>  /* TCP emulations */
> @@ -51,21 +49,9 @@ struct emu_t {
>      struct emu_t *next;
>  };
>  
> -extern int x_port, x_server, x_display;
> -
> -int show_x(char *, struct socket *);
> -void redir_x(uint32_t, int, int, int);
>  void slirp_insque(void *, void *);
>  void slirp_remque(void *);
>  int add_exec(struct ex_list **, int, char *, struct in_addr, int);
> -int slirp_openpty(int *, int *);
>  int fork_exec(struct socket *so, const char *ex, int do_pty);
> -void snooze_hup(int);
> -void snooze(void);
> -void relay(int);
> -void add_emu(char *);
> -void fd_nonblock(int);
> -void fd_block(int);
> -int rsh_exec(struct socket *, struct socket *, char *, char *, char *);
>  
>  #endif
> 

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux



reply via email to

[Prev in Thread] Current Thread [Next in Thread]