qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH trivial] configure: explicitly disable virtfs


From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH trivial] configure: explicitly disable virtfs if softmmu=no
Date: Tue, 11 Jun 2013 00:57:34 +0400
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0

11.06.2013 00:47, Michael Tokarev wrote:
> Or else
> 
>  ./configure --disable-system --enable-virtfs
> 
> (which makes no sense by its own but does not error out)
> will fail to build, because it will define CONFIG_VIRTFS,
> and the makefile will try to build virtfs-proxy-helper
> manpage (but not the executable).

The build fails in this case in a separate build tree, because
the fsdev directory is not created and scripts/texi2pod.pl
will be called with output = fsdev/virtfs-proxy-helper.pod,
which can't be created because fsdev/ does not exist.

> 
> Cc: address@hidden
> Cc: M. Mohan Kumar <address@hidden>
> Signed-off-by: Michael Tokarev <address@hidden>
> ---
>  configure |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/configure b/configure
> index a3f0b7a..0ff0380 100755
> --- a/configure
> +++ b/configure
> @@ -3423,6 +3423,8 @@ if test "$softmmu" = yes ; then
>        tools="qemu-ga\$(EXESUF) $tools"
>      fi
>    fi
> +else
> +  virtfs=no
>  fi
>  
>  # Mac OS X ships with a broken assembler
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]