[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2 5/5] ui: boolize 'full_screen'
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-trivial] [PATCH v2 5/5] ui: boolize 'full_screen' |
Date: |
Wed, 19 Jun 2013 12:37:04 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 |
18.06.2013 07:45, liguang wrote:
[]
> -void sdl_display_init(DisplayState *ds, int full_screen, int no_frame);
> +void sdl_display_init(DisplayState *ds, bool full_screen, int no_frame);
The same applies to no_frame, isn't it?
These conversions to bool are like this -- "thankless", because there are
so many of them all around, you touch one place and it becomes obvious
that nearby places should be touched too. Like this:
> --- a/vl.c
> +++ b/vl.c
> @@ -198,7 +198,7 @@ static int rtc_utc = 1;
> static int rtc_date_offset = -1; /* -1 means no change */
> QEMUClock *rtc_clock;
> int vga_interface_type = VGA_NONE;
> -static int full_screen = 0;
> +static bool full_screen = false;
> static int no_frame = 0;
> int no_quit = 0;
This no_quit is bool too... :) But I think _this_ one might be in a
separate patch. But it is also display-specific.
Besides, I think we should rewamp this display init thing entirely,
making displays to be modules and implementing options parsing
properly.
I think I'll do that today, and will convert these to bools while
at it.
Thanks,
/mjt
- [Qemu-trivial] [PATCH v2 1/5] vnc: pass bool para meter for some functions, liguang, 2013/06/18
- [Qemu-trivial] [PATCH v2 2/5] vnc: boolize 'skipauth', liguang, 2013/06/18
- [Qemu-trivial] [PATCH v2 3/5] qemu-char: use bool in qemu_chr_open_socket, liguang, 2013/06/18
- [Qemu-trivial] [PATCH v2 4/5] sd: pass bool parameter for sd_init, liguang, 2013/06/18
- [Qemu-trivial] [PATCH v2 5/5] ui: boolize 'full_screen', liguang, 2013/06/18
- Re: [Qemu-trivial] [PATCH v2 5/5] ui: boolize 'full_screen',
Michael Tokarev <=
- Re: [Qemu-trivial] [PATCH v2 1/5] vnc: pass bool parameter for some functions, Michael Tokarev, 2013/06/19