[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] slirp: reorder include to fix Fr
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] slirp: reorder include to fix FreeBSD build failure |
Date: |
Wed, 17 Jul 2013 10:32:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-07-14 00:35, Ed Maste wrote:
> On 13 July 2013 05:12, Michael Tokarev
> <address@hidden<mailto:address@hidden>> wrote:
> Remaining:
>
> struct mbuf {
> union M_dat {
> char m_dat_[1]; /* ANSI don't like 0 sized arrays */
> char *m_ext_;
> } M_dat;
> };
>
> #define m_dat M_dat.m_dat_
> #define m_ext M_dat.m_ext_
>
> This can be done by using an unnamed union, ie, by omitting
>
> Yeah, struct mbuf and those #defines date back to the beginning of BSD
> networking.
>
> I think we're probably unconcerned with a slirp upstream at this point, so
> such a change seems reasonable.
Indeed, they are always welcome. There is no point in tracking upstream
anymore.
> I'm not sure that anonymous union support is universal across all compilers
> used to build QEMU though - do you know?
No problem, as Peter already said. Please provide an according patch.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux