qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] PPC: dbdma: macio: Fix format sp


From: Andreas Färber
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] PPC: dbdma: macio: Fix format specifiers (build regression)
Date: Sat, 20 Jul 2013 16:24:58 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7

Am 19.07.2013 20:59, schrieb Stefan Weil:
> Am 19.07.2013 00:40, schrieb Alexander Graf:
>> On 18.07.2013, at 21:49, Stefan Weil wrote:
>>> Am 16.07.2013 07:54, schrieb Stefan Weil:
>>>> Am 12.07.2013 18:48, schrieb Stefan Weil:
>>>>> Hi Anthony,
>>>>>
>>>>> the patch fixes a build regression which was introduced today.
>>>>> Could you please apply it without waiting for the next pull requests?
>>>>>
>>>>> Thanks,
>>>>> Stefan
> [...]
>> Acked-by: Alexander Graf <address@hidden> I assume this can go through
>> the trivial tree? Or directly get applied by Anthony? Alex 
> 
> 
> I still think that build regressions should be fixed by a direct
> maintainer commit instead of waiting for a pull request,
> but obviously this does not happen here (why?).

Anthony recently stated very clearly that in order for him to pick up a
patch it needs to have a Reviewed-by. This one only got an Acked-by.

> So hopefully the fix will be committed via qemu-trivial at least.

It's not obvious from the diff context whether those specifiers are in
fact correct, and there is an active maintainer, so in theory it
wouldn't qualify for -trivial.

Alex, don't be lazy and just send a one-patch PULL like Cornelia did for
her recent mingw breakage. :)

Andreas

> See http://patchwork.ozlabs.org/patch/258774/ for the full patch.
> 
> Stefan

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]