Re: [Qemu-trivial] [PATCH v3] slirp: Port redirection option behave differently on Linux and Windows

[Mirza, Taimoor]

Hi Guys,

Thanks for reviewing the patch. Only difference between v2 and v3 is that v2 
had an extra character added at top of the file (socket.c). This was removed in 
v3.

Regards,
Taimoor


________________________________________
From: Stefan Weil address@hidden
Sent: Sunday, September 01, 2013 9:13 PM
To: Michael Tokarev
Cc: Jan Kiszka; address@hidden; Mirza, Taimoor; address@hidden
Subject: Re: [Qemu-trivial] [PATCH v3] slirp: Port redirection option behave 
differently on Linux and Windows

Am 01.09.2013 17:46, schrieb Michael Tokarev:
> 30.08.2013 15:04, Jan Kiszka wrote:
>> On 2013-08-15 21:25, Taimoor wrote:
>>> From: Taimoor Mirza <address@hidden>
>>>
>>> port redirection code uses SO_REUSEADDR socket option before binding to
>>> host port. Behavior of SO_REUSEADDR is different on Windows and Linux.
>>> Relaunching QEMU with same host and guest port redirection values on
>>> Linux
>>> throws error but on Windows it does not throw any error.
>>> Problem is discussed in
>>> http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03089.html
> []
>> Stefan, can you ack this? Then I would pick it up for the slirp queue.
>
> I remember having exactly the same issue myself a few years back with
> the difference of SO_REUSEADDR behavour on windows and *nix, and the
> suggested change appears to be correct.  So you can count on my
>
> Reviewed-by: Michael Tokarev <address@hidden>
>
> as well.
>
> I applied the v2 of this patch (with a trivial fix) to trivial queue
> (before seeing this v3), I can remove it if you like.
>
> Thanks,
>
> /mjt

Hi Michael,

thanks for your review of this patch. I had no opportunity to test
it myself, but I also think that it is fine.

(v2 + trivial fix) should be identical to v3, so this looks good, too.

Cheers,
Stefan