Re: [Qemu-trivial] [Qemu-devel] [PATCH] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)

[Richard Henderson]

On 09/12/2013 11:57 AM, Stefan Weil wrote:
> Thanks for your hint. Yes, as you can see from tcg/tci/README,the test
> matrix of TCI
> did not include big endian hosts up to now. Testing on an emulated big
> endian Malta
> system is terribly slow, and I have no access to real big endian
> hardware fortests.

Recall that we're not necessarily talking about big-endian host,
but big-endian target on little-endian host.  I don't see any
byte swapping going on here at all.

FYI, the smoke-test I use for big-endian is

$ qemu-system-sparc -nographic
Configuration device id QEMU version 1 machine id 32
CPUs: 1 x FMI,MB86904
UUID: 00000000-0000-0000-0000-000000000000
Welcome to OpenBIOS v1.1 built on Jul 30 2013 21:43
  Type 'help' for detailed information
Trying disk...
No valid state has been set by load or init-program

0 >

At which point you can signal the monitor to exit with ctrl-a x.

> But I think that such changes are independent of this patchwhich can be
> applied as it is.

Fair enough.  In which case

Reviewed-by: Richard Henderson <address@hidden>


r~