[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor
From: |
Fabien Chouteau |
Subject: |
Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands |
Date: |
Wed, 25 Sep 2013 17:38:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 |
On 09/25/2013 01:53 AM, Peter Maydell wrote:
>
> No, I really don't want to see another target #ifdef ladder, please.
> Put a 'static const MonitorDef *monitor_defs;' into CPUClass,
> and initialize it in each target's class init function, please.
> (You'll need to move the appropriate sections of the current
> static array in monitor.c plus the per-target functions that
> it references into target-*/cpu.c.) Look at gdb_num_core_regs
> as an example of where we made this kind of abstraction.
>
I tried already. Where whould you put the declaration of MonitorDef type?
--
Fabien Chouteau
- [Qemu-trivial] [PATCH 0/3] Few minor improvements of monitor disas command (v2), Fabien Chouteau, 2013/09/24
- [Qemu-trivial] [PATCH 2/3] Improve Monitor disas with symbol lookup, Fabien Chouteau, 2013/09/24
- [Qemu-trivial] [PATCH 1/3] Fix coding style, Fabien Chouteau, 2013/09/24
- [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Fabien Chouteau, 2013/09/24
- Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Peter Maydell, 2013/09/24
- Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands,
Fabien Chouteau <=
- Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Peter Maydell, 2013/09/25
- Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Fabien Chouteau, 2013/09/25
- Re: [Qemu-trivial] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Peter Maydell, 2013/09/25
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Fabien Chouteau, 2013/09/26
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands, Peter Maydell, 2013/09/26