Re: [Qemu-trivial] [PATCH v3 1/2] tests: Fix schema parser test for in-tree build

[Michael Tokarev]

24.09.2013 11:43, address@hidden wrote:
> From: Markus Armbruster <address@hidden>
>
> Commit 4f193e3 added the test, but screwed up in-tree builds
> (SRCDIR=.): the tests's output overwrites the expected output, and is
> thus compared to itself.

[]
>   .PHONY: $(patsubst %, check-%, $(check-qapi-schema-y))
>   $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: 
> $(SRC_PATH)/%.json
> -       $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts $(PYTHON) 
> $(SRC_PATH)/tests/qapi-schema/test-qapi.py <$^ >$*.out 2>$*.err; echo $$? >$*.exit, 
> "  TEST  $*.out")
> -       @diff -q $(SRC_PATH)/$*.out $*.out
> -       @diff -q $(SRC_PATH)/$*.err $*.err
> -       @diff -q $(SRC_PATH)/$*.exit $*.exit
> +       $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts $(PYTHON) 
> $(SRC_PATH)/tests/qapi-schema/test-qapi.py <$^ >$*.test.out 2>$*.test.err; echo $$? 
> >$*.test.exit, "  TEST  $*.out")
> +       @diff -q $(SRC_PATH)/$*.out $*.test.out
> +       @diff -q $(SRC_PATH)/$*.err $*.test.err
> +       @diff -q $(SRC_PATH)/$*.exit $*.test.exit

Hmm.  Maybe these new files should be cleaned up somehow by
`make clean' ?

Thanks,

/mjt