qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] vl: fix build when configured with no graphic


From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH] vl: fix build when configured with no graphic support
Date: Fri, 01 Nov 2013 14:29:24 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130922 Icedove/17.0.9

29.10.2013 08:36, Antony Pavlov wrote
The following error occurs when building no graphic output support:

   vl.c: In function ‘main’:
   vl.c:2829:19: error: variable ‘ds’ set but not used 
[-Werror=unused-but-set-variable]
        DisplayState *ds;
                      ^
   cc1: all warnings being treated as errors

Thanks, applied to the trivial-patches queue.

While at it, I also added a comment to the line being added,
telling what this is all about:

--- a/vl.c
+++ b/vl.c
@@ -4269,6 +4269,7 @@ int main(int argc, char **argv, char **envp)
     /* init local displays */
     switch (display_type) {
     case DT_NOGRAPHIC:
+        (void)ds;      /* avoid warning if no display is configured */
         break;
 #if defined(CONFIG_CURSES)
     case DT_CURSES:

Hopefully it is okay... ;)

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]