[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] acpi unit-test: Create temporary disk file un
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-trivial] [PATCH] acpi unit-test: Create temporary disk file under /tmp |
Date: |
Fri, 20 Dec 2013 08:36:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 20/12/2013 08:05, Fam Zheng ha scritto:
> As other tests, the image file is created in /tmp other than current
> dir. Thus there will not be an unignored file under tests for intree
> build.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/acpi-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/acpi-test.c b/tests/acpi-test.c
> index ca83b1d6..e4f31b7 100644
> --- a/tests/acpi-test.c
> +++ b/tests/acpi-test.c
> @@ -116,7 +116,7 @@ static uint8_t boot_sector[0x200] = {
> [0x1FF] = 0xAA,
> };
>
> -static const char *disk = "tests/acpi-test-disk.raw";
> +static const char *disk = "/tmp/qtest-acpi-test-disk.raw";
>
> static void free_test_data(test_data *data)
> {
>
The real bug is probably that the file is not unlinked.
Using /tmp is a good idea, but if you do that you probably need to take
TMPDIR into account.
Paolo