[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3] mainstone: Fix duplicate array values for
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-trivial] [PATCH v3] mainstone: Fix duplicate array values for key 'space' |
|
Date: |
Sun, 22 Dec 2013 19:51:45 +0000 |
On 22 December 2013 19:42, Stefan Weil <address@hidden> wrote:
> cgcc reported a duplicate initialisation. Mainstone includes a matrix
> keyboard where two different positions map to 'space'.
>
> QEMU uses the reversed mapping and does not map 'space' to two different
> matrix positions.
>
> Some other keys are either missing or might be mapped wrongly (cf. Linux
> kernel code). Don't fix these until someone can test them with real
> hardware, but add TODO comments.
>
> Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM