|
From: | Kewei Yu |
Subject: | Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang |
Date: | Fri, 3 Jan 2014 11:01:59 +0800 |
Am 01.01.2014 05:40, schrieb Peter Crosthwaite:
> On Tue, Dec 31, 2013 at 11:29 PM, Kewei Yu <address@hidden> wrote:[...]
>> 2013/12/31 Peter Crosthwaite <address@hidden>
>>> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu <address@hidden> wrote:
>>>> When we disabling vnc from "./configure", the qemu can't use the vnc
>>>> option.
>>>> So qtest can't use the "vnc -none ", otherwise "make check" will hang.Actually no. When qtest gets an unsupported command line argument, so
>>>
>>> Curious, why exactly does make check hang? Shouldn't it just fail with
>>> an error result in this case?
>>
>> Yeah, there is an error result "VNC support is disabled".
>
> I think its just terminology then. s/hangs/fails.
that QEMU exits right away, then qtest hangs, waiting for the process.
This was easily reproducible by mistyping machine names in my qom-test.
That's a separate issue though.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[Prev in Thread] | Current Thread | [Next in Thread] |