Re: [Qemu-trivial] [Qemu-devel] [PATCH] virtio-balloon: don't hardcode config size value

[Peter Crosthwaite]

On Fri, Jan 10, 2014 at 12:58 AM, Luiz Capitulino
<address@hidden> wrote:
> Use sizeof(strucy virtio_balloon_config) instead.
>

"struct".

> Signed-off-by: Luiz capitulino <address@hidden>

Otherwise:

Reviewed-by: Peter Crosthwaite <address@hidden>

> ---
>
> I have no idea which queue this should go through...
>

Trivial?

Regards,
Peter

>  hw/virtio/virtio-balloon.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> index d9754db..a470a0b 100644
> --- a/hw/virtio/virtio-balloon.c
> +++ b/hw/virtio/virtio-balloon.c
> @@ -263,7 +263,7 @@ static void virtio_balloon_get_config(VirtIODevice *vdev, 
> uint8_t *config_data)
>      config.num_pages = cpu_to_le32(dev->num_pages);
>      config.actual = cpu_to_le32(dev->actual);
>
> -    memcpy(config_data, &config, 8);
> +    memcpy(config_data, &config, sizeof(struct virtio_balloon_config));
>  }
>
>  static void virtio_balloon_set_config(VirtIODevice *vdev,
> @@ -272,7 +272,7 @@ static void virtio_balloon_set_config(VirtIODevice *vdev,
>      VirtIOBalloon *dev = VIRTIO_BALLOON(vdev);
>      struct virtio_balloon_config config;
>      uint32_t oldactual = dev->actual;
> -    memcpy(&config, config_data, 8);
> +    memcpy(&config, config_data, sizeof(struct virtio_balloon_config));
>      dev->actual = le32_to_cpu(config.actual);
>      if (dev->actual != oldactual) {
>          qemu_balloon_changed(ram_size -
> @@ -343,7 +343,8 @@ static void virtio_balloon_device_realize(DeviceState 
> *dev, Error **errp)
>      VirtIOBalloon *s = VIRTIO_BALLOON(dev);
>      int ret;
>
> -    virtio_init(vdev, "virtio-balloon", VIRTIO_ID_BALLOON, 8);
> +    virtio_init(vdev, "virtio-balloon", VIRTIO_ID_BALLOON,
> +                sizeof(struct virtio_balloon_config));
>
>      ret = qemu_add_balloon_handler(virtio_balloon_to_target,
>                                     virtio_balloon_stat, s);
> --
> 1.8.1.4
>
>