Re: [Qemu-trivial] [Qemu-devel] [PATCH] object: Report type in error when not user creatable.

[Hu Tao]

cced: Igor

On Tue, Feb 18, 2014 at 11:42:36PM +0100, Hani Benhabiles wrote:
> Signed-off-by: Hani Benhabiles <address@hidden>
> ---
>  qmp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qmp.c b/qmp.c
> index d0d98e7..f556a04 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -556,8 +556,8 @@ void object_add(const char *type, const char *id, const 
> QDict *qdict,
>      }
>  
>      if (!object_dynamic_cast(obj, TYPE_USER_CREATABLE)) {
> -        error_setg(&local_err, "object '%s' isn't supported by object-add",
> -                   id);
> +        error_setg(&local_err, "object type '%s' isn't supported by 
> object-add",
> +                   type);
>          goto out;
>      }

Same problem here. In the case what we should let user know is the
type of object, instead of id which is just a normal property of object.

Reviewed-by: Hu Tao <address@hidden>