[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] util: Add 'static' attribute to
From: |
Richard Henderson |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] util: Add 'static' attribute to function implementation |
Date: |
Sun, 16 Mar 2014 11:06:57 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/16/2014 11:02 AM, Stefan Weil wrote:
> 'static' is used in the forward declaration, but not in the implementation.
> Add it there, too.
You might consider reporting this as a bug in the analyzer, since the static in
the forward declaration does apply to the definition.
That said, for style it's usually better to make them match, so,
Reviewed-by: Richard Henderson <address@hidden>
r~