Re: [Qemu-trivial] [PATCH v2 2/3] block: Replaced old error handling with error reporting API.

[Kevin Wolf]

Am 18.03.2014 um 06:59 hat Maria Kustova geschrieben:
> Signed-off-by: Maria Kustova <address@hidden>
> ---
> Changes v1 -> v2:
>  * Removed trailing "\n" from the error string
> ---
>  block/curl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/curl.c b/block/curl.c
> index 3494c6d..359637e 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -538,8 +538,7 @@ static int curl_open(BlockDriverState *bs, QDict 
> *options, int flags,

Did you manually edit this patch? It is corrupted and I had to manually
s/538,8/538,7/ before I could apply it.

Kevin

>      return 0;
>  
>  out:
> -    fprintf(stderr, "CURL: Error opening file: %s\n", state->errmsg);
> +    error_setg(errp, "CURL: Error opening file: %s", state->errmsg);
>      curl_easy_cleanup(state->curl);
>      state->curl = NULL;
>  out_noclean:
> -- 
> 1.8.2.1
>