[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH trivial 0/3] vl: simplify code for main() and get_
From: |
Chen Gang |
Subject: |
[Qemu-trivial] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device() |
Date: |
Tue, 08 Apr 2014 20:00:20 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
In "vl.c", at least, we can simplify the code below, so can let readers
read professional C code (especially for new readers, which often start
reading code at main function).
- remove useless 'continue' in main().
- remove redundant local variable 'res' in get_boot_device().
- remove local variable 'args' in the middle of code block in main().
The following 3 patches are for the 3 'remove' above.
And "vl.c" has a very long function main() which is about 17K lines.
Next, it can be split into sub-functions (so can bypass another code
style issue: multiple "{...}" styles within "swith(...)").
Signed-off-by: Chen Gang <address@hidden>
---
vl.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
- [Qemu-trivial] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely, Chen Gang, 2014/04/04
- Re: [Qemu-trivial] [Qemu-devel] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely, Markus Armbruster, 2014/04/04
- Re: [Qemu-trivial] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely, Michael Tokarev, 2014/04/06
- Re: [Qemu-trivial] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely, Chen Gang, 2014/04/06
- [Qemu-trivial] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device(),
Chen Gang <=
- [Qemu-trivial] [PATCH trivial 1/3] vl: remove useless 'continue', Chen Gang, 2014/04/08
- [Qemu-trivial] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Chen Gang, 2014/04/08
- [Qemu-trivial] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/08
- Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Markus Armbruster, 2014/04/15
- Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/15
- Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Peter Crosthwaite, 2014/04/15
- Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block, Chen Gang, 2014/04/15
- Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Peter Crosthwaite, 2014/04/14
- Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Chen Gang, 2014/04/15
- Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res', Markus Armbruster, 2014/04/15