[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 14/18] virtfs-proxy-helper: fix call to accept
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 14/18] virtfs-proxy-helper: fix call to accept |
Date: |
Mon, 28 Apr 2014 09:08:00 +0400 |
From: Tim Comer <address@hidden>
The current code calls accept() without initializing the size parameter
which means the accept call might write too much to the stack.
URL: https://bugs.gentoo.org/486714
Signed-off-by: Tim Comer <address@hidden>
Signed-off-by: Mike Frysinger <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
fsdev/virtfs-proxy-helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index bfecb87..cd291d3 100644
--- a/fsdev/virtfs-proxy-helper.c
+++ b/fsdev/virtfs-proxy-helper.c
@@ -760,6 +760,7 @@ static int proxy_socket(const char *path, uid_t uid, gid_t
gid)
return -1;
}
+ size = sizeof(qemu);
client = accept(sock, (struct sockaddr *)&qemu, &size);
if (client < 0) {
do_perror("accept");
--
1.7.10.4
- [Qemu-trivial] [PULL 06/18] tests/.gitignore: Ignore test-rfifolock, (continued)
- [Qemu-trivial] [PULL 06/18] tests/.gitignore: Ignore test-rfifolock, Michael Tokarev, 2014/04/28
- [Qemu-trivial] [PULL 04/18] configure: Improve help behavior, Michael Tokarev, 2014/04/28
- [Qemu-trivial] [PULL 18/18] slirp/smb: Move ncalrpc directory to tmp, Michael Tokarev, 2014/04/28
- [Qemu-trivial] [PULL 09/18] vl: Eliminate a superfluous local variable, Michael Tokarev, 2014/04/28
- [Qemu-trivial] [PULL 08/18] vl: Remove useless 'continue', Michael Tokarev, 2014/04/28
- [Qemu-trivial] [PULL 16/18] po/Makefile: fix $SRC_PATH reference, Michael Tokarev, 2014/04/28
- [Qemu-trivial] [PULL 15/18] init_paths: fix minor memory leak, Michael Tokarev, 2014/04/28
- [Qemu-trivial] [PULL 11/18] vl: avoid closing stdout with 'writeconfig', Michael Tokarev, 2014/04/28
- [Qemu-trivial] [PULL 10/18] xilinx: Fix typo in comment (Marvel -> Marvell), Michael Tokarev, 2014/04/28
- [Qemu-trivial] [PULL 17/18] po: add proper Langua ge: tags to .po files, Michael Tokarev, 2014/04/28
- [Qemu-trivial] [PULL 14/18] virtfs-proxy-helper: fix call to accept,
Michael Tokarev <=
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/18] Trivial patches for 2014-04-28, Peter Maydell, 2014/04/28