qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH V5 1/1] qmp: add pmemload command


From: Markus Armbruster
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH V5 1/1] qmp: add pmemload command
Date: Mon, 28 Apr 2014 08:30:56 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Michael Tokarev <address@hidden> writes:

> 09.04.2014 21:49, Baojun Wang wrote:
>> I found this could be useful to have qemu-softmmu as a cross debugger (launch
>> with -s -S command line option), then if we can have a command to load guest
>> physical memory, we can use cross gdb to do some target debug which gdb 
>> cannot
>> do directly.
>> 
>> Many thanks to Eric Blake for review the patch and suggestions.
>
> Okay, that looks sane, but can you explain please, why did you address
> address@hidden  The change definitely is not "trivial", as it introduces
> a new qmp command which becomes a part of public interface.  Even if
> the implementation may look trivial, the interface change should not be
> done using -trivial tree.

Yes.  Copying Luiz.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]