Re: [Qemu-trivial] [PATCH 2/2] block: replace fprintf(stderr, ...) with error_report()

[Le Tan]

I will fix the whitespace issues and resend this series with a new
version later.
Thanks very much! ;)

Le

2014-05-24 4:27 GMT+08:00 Michael Tokarev <address@hidden>:
> 21.05.2014 04:10, Le Tan wrote:
>> Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
>> block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument
>> have been removed because @fmt of error_report() should not contain newline.
>>
>> Signed-off-by: Le Tan <address@hidden>
>> ---
>>  block-migration.c      |    5 +--
>>  block.c                |    4 +-
>>  block/qcow2-refcount.c |  114 
>> ++++++++++++++++++++++++------------------------
>>  block/qcow2.c          |   18 ++++----
>>  block/raw-posix.c      |   10 ++---
>>  block/raw-win32.c      |    6 +--
>>  block/ssh.c            |    2 +-
>>  block/vdi.c            |   15 ++++---
>>  block/vmdk.c           |   15 +++----
>>  block/vpc.c            |    4 +-
>>  block/vvfat.c          |   69 +++++++++++++++--------------
>>  blockdev.c             |    6 +--
>>  12 files changed, 132 insertions(+), 136 deletions(-)
>
> That's a rather large -trivial patch... ;)
>
> Please check this patch using ./tools/checkpatch.pl - it will show
> many whitespace issues.
>
> I'd apply it to -trivial (after fixing the whitespace issues), all
> the actual changes look sane.  But Cc'ing kwolf and stefanha too
> (who are the block subsystem maintainers), because the patch touches
> too many of block code.
>
> Thanks,
>
> /mjt
>