qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qtest: fix hex2nib for capital c


From: Markus Armbruster
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qtest: fix hex2nib for capital characters
Date: Tue, 27 May 2014 13:44:49 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

address@hidden writes:

> From: Sergey Fedorov <address@hidden>
>
> Signed-off-by: Sergey Fedorov <address@hidden>
>
> ---
>  qtest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qtest.c b/qtest.c
> index 2aba20d..87ccd62 100644
> --- a/qtest.c
> +++ b/qtest.c
> @@ -148,7 +148,7 @@ static int hex2nib(char ch)
>      } else if (ch >= 'a' && ch <= 'f') {
>          return 10 + (ch - 'a');
>      } else if (ch >= 'A' && ch <= 'F') {
> -        return 10 + (ch - 'a');
> +        return 10 + (ch - 'A');
>      } else {
>          return -1;
>      }

Awesome testing on the original author's part %-}

Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]