[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] cpu/x86: correctly set errors in x86_cpu_pars
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-trivial] [PATCH] cpu/x86: correctly set errors in x86_cpu_parse_featurestr |
|
Date: |
Sun, 08 Jun 2014 17:43:20 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 |
06.06.2014 17:21, Paolo Bonzini wrote:
> Because of the "goto out", the contents of local_err are leaked
> and lost.
Might just as well change 'goto out' to 'break' (instead of return),
and handle the `if (local_err)' like you did.
Applied to -trivial, thank you!
/mjt