[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attrib
From: |
Richard Henderson |
Subject: |
Re: [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused' |
Date: |
Sun, 08 Jun 2014 12:34:01 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/08/2014 12:04 PM, Peter Maydell wrote:
> The other approach we could take would be to move these
> definitions from this .c file into a .h file (tcg-backend-helpers.h ?).
> Then clang won't complain (it seems to only warn about unused
> static-inline-functions in .c files, not in .h files).
>
> Richard: do you have a preference?
I don't like the idea of moving these to a public header, and I don't think
it's worthwhile creating a new private header. I'm ok with the unused
attribute.
r~