|
From: | Alexander Graf |
Subject: | Re: [Qemu-trivial] [PATCH] target-ppc: Fix compiler warning |
Date: | Tue, 17 Jun 2014 21:40:07 +0200 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 17.06.14 19:18, Stefan Weil wrote:
gcc reports a warning which is usually wrong: target-ppc/dfp_helper.c: In function ‘dfp_get_digit’: target-ppc/dfp_helper.c:417:1: warning: control reaches end of non-void function [-Wreturn-type] The compiler shows the warning if assert is not marked with the noreturn attribute or if the code is compiled with -DNDEBUG. Using g_assert_not_reached better documents the intention and does not have these problems. Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Alexander Graf <address@hidden> Please take it via -trivial. Alex
[Prev in Thread] | Current Thread | [Next in Thread] |