Re: [Qemu-trivial] [Qemu-devel] [PATCH] block/vvfat.c: remove debugging code to reinit stderr if NULL

[Peter Maydell]

On 18 August 2014 12:41, Michael Tokarev <address@hidden> wrote:
> Just log to stderr unconditionally, like other similar code does.
>
> Signed-off-by: Michael Tokarev <address@hidden>
> ---
>  block/vvfat.c |    5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 70176b1..ea37023 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -1082,11 +1082,6 @@ static int vvfat_open(BlockDriverState *bs, QDict 
> *options, int flags,
>      vvv = s;
>  #endif
>
> -DLOG(if (stderr == NULL) {
> -    stderr = fopen("vvfat.log", "a");
> -    setbuf(stderr, NULL);
> -})
> -
>      opts = qemu_opts_create(&runtime_opts, NULL, 0, &error_abort);
>      qemu_opts_absorb_qdict(opts, options, &local_err);
>      if (local_err) {
> --
> 1.7.10.4

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM