qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v7] tests/bios-tables-test: check the value re


From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH v7] tests/bios-tables-test: check the value returned by fopen()
Date: Mon, 18 Aug 2014 18:24:02 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.7.0

18.08.2014 17:44, Michael S. Tsirkin wrote:
> On Mon, Aug 18, 2014 at 03:38:12PM +0400, Michael Tokarev wrote:
>> 18.08.2014 11:54, zhanghailiang wrote:
>>> The function fopen() may fail, so check its return value.
>>>
>>> Signed-off-by: zhanghailiang <address@hidden>
>>> Signed-off-by: Li Liu <address@hidden>
>>> Reviewed-by: Alex Bennée <address@hidden>
>>> ---
>>>  tests/bios-tables-test.c | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
>>> index 045eb27..feb3b58 100644
>>> --- a/tests/bios-tables-test.c
>>> +++ b/tests/bios-tables-test.c
>>> @@ -790,6 +790,11 @@ int main(int argc, char *argv[])
>>>      const char *arch = qtest_get_arch();
>>>      FILE *f = fopen(disk, "w");
>>>      int ret;
>>> +
>>> +    if (!f) {
>>> +        fprintf(stderr, "Couldn't open \"%s\": %s", disk, strerror(errno));
>>> +        return -1;
>>> +    }
>>
>> Applied to -trivial, with s/-1/1/.  No need to resend it again.
>>
>> Thanks,
>>
>> /mjt
>>
>>>      fwrite(boot_sector, 1, sizeof boot_sector, f);
>>>      fclose(f);
> 
> This doesn't seem appropriate to trivial tree:
> there were some objections from Marcel, I'd like to
> see them addressed.

I see the objections as addressed, don't you?

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]