[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v8] slirp/misc: Use the GLib memory allocation
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-trivial] [PATCH v8] slirp/misc: Use the GLib memory allocation APIs |
Date: |
Wed, 20 Aug 2014 18:57:58 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.7.0 |
19.08.2014 12:30, zhanghailiang wrote:
> Here we don't check the return value of malloc() which may fail.
> Use the g_new() instead, which will abort the program when
> there is not enough memory.
>
> Also, use g_strdup instead of strdup and remove the unnecessary
> strdup function.
I also will remove the HAVE_STRDUP define from slirp_config.h --
it is no longer needed there.
Applied to -trivial (with the above addition), thank you!
/mjt