[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] target-xtensa: mark XtensaConfig structs as u
|
From: |
Max Filippov |
|
Subject: |
Re: [Qemu-trivial] [PATCH] target-xtensa: mark XtensaConfig structs as unused |
|
Date: |
Fri, 10 Oct 2014 21:20:34 +0400 |
On Fri, Oct 10, 2014 at 8:24 PM, Peter Maydell <address@hidden> wrote:
> On 14 September 2014 21:29, Max Filippov <address@hidden> wrote:
>> On Sun, Sep 14, 2014 at 12:36 PM, Peter Maydell
>> <address@hidden> wrote:
>>> The XtensaConfig structs will be defined but not used if they are
>>> for the opposite endianness from that of the binary being built;
>>> keep the compiler from complaining about this by marking them
>>> with the 'unused' attribute.
>>>
>>> Signed-off-by: Peter Maydell <address@hidden>
>>> ---
>>> This works, although it's a tad ugly. If anybody wants to suggest
>>> something better...
>>
>> Fine for me.
>>
>>> target-xtensa/core-dc232b.c | 2 +-
>>> target-xtensa/core-dc233c.c | 2 +-
>>> target-xtensa/core-fsf.c | 2 +-
>>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> Acked-by: Max Filippov <address@hidden>
>
> Thanks. I guess we could put this one in through
> -trivial ?
Yes, please.
> Patchwork url:
> http://patchwork.ozlabs.org/patch/389115/
--
Thanks.
-- Max