Re: [Qemu-trivial] [PATCH] vl.c: Fix Coverity complaining for vmstate_dump_file

[Amit Shah]

On (Wed) 29 Oct 2014 [20:49:43], address@hidden wrote:
> From: Gonglei <address@hidden>
> 
> commit abfd9ce3(migration: dump vmstate info as a json
> file for static analysis) introduce a new command,
> '-dump-vmstate', that takes a filename
> as an argument.  When executed, QEMU will dump the vmstate information
> for the machine type it's invoked with to the file, and quit.
> 
> Apparently, it supports one '-dump-vmstate' option,
> otherwise, the vmstate_dump_file will be overwritten.

Suggested re-wording of this para:

However, only one instance of the -dump-vmstate option is supported.
If more were given, the vmstate_dump_file could be overwritten.

> Of course, the resource will be freed when Qemu quit, but The code logic
> is not good, it will make Coverity complaining.

Suggested re-wording:

This fix also helps silence a Coverity error.

> Signed-off-by: Gonglei <address@hidden>

Reviewed-by: Amit Shah <address@hidden>

Thanks,

                Amit