[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] dump: fix use-after-free for
|
From: |
Gonglei |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] dump: fix use-after-free for s->fd |
|
Date: |
Fri, 31 Oct 2014 09:43:31 +0800 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 |
On 2014/10/30 21:54, Michael Tokarev wrote:
> So I'm applying this -- which is your patch and your commit message, and
> I really wonder why this is Reviewed-by and not Signed-off-by, with your
> authorship? It really should be...
Yes, maybe it should be. But I have to say something:
First, I posted a patch fix the fd leak problem. Markus reviewed it and gave
his reviewing comments which I think is better, and then I posted
the version 2 with Markus' suggestion. As your meaning, I should add the
Signed-off-by tag of Markus? But for me, I don't get Markus' authorization,
so I can't do this, and maybe he have other comments for version 2.
Best regards,
-Gonglei