qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq


From: Paolo Bonzini
Subject: Re: [Qemu-trivial] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq
Date: Wed, 12 Nov 2014 12:41:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0


On 12/11/2014 12:29, Fam Zheng wrote:
> The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading
> comment.
> 
> Suggested-by: Markus Armbruster <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  include/hw/virtio/virtio-scsi.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index 9e1a49c..bf17cc9 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq {
>      /* Note:
>       * - fields before elem are initialized by virtio_scsi_init_req;
>       * - elem is uninitialized at the time of allocation.
> -     * - fields after elem are zeroed by virtio_scsi_init_req.
> +     * - fields after elem (except the ending cdb[]) are zeroed by
> +     *   virtio_scsi_init_req.
>       * */
>  
>      VirtQueueElement elem;
> 

Applied, thanks.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]