[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] vt82c686: avoid out-of-bounds read
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-trivial] [PATCH] vt82c686: avoid out-of-bounds read |
|
Date: |
Thu, 11 Dec 2014 20:55:04 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 |
10.12.2014 12:17, Paolo Bonzini wrote:
> superio_ioport_readb can read the 256th element of the array.
Is there a legitimate reason for it to access byte index 256?
What is the actual size of superio config memory, 256 or 257?
I don't know, but somehow it looks like it should be 256.
If that's the case, the fix is wrong and superio_ioport_readb()
should be fixed instead...
Thanks,
/mjt