Re: [Qemu-trivial] [Qemu-devel] [PATCH] tcg: Use macro instead of hard code number 0xffffffff for tcg_target_ulong using

[Gang Chen]

It is not for fixing bugs. I guess it belongs to trivial patch (not fix bugs, not changing any working flow).

And excuse me, gmail is broken again, in China, I have to reply on web site via my Mac book Safari (which is not a pure text).

On Mon, Jan 19, 2015 at 11:58 PM, Peter Maydell <address@hidden> wrote:

On 19 January 2015 at 15:34, Chen Gang <address@hidden> wrote:
> For tcg_target_ulong (include TCGArg), it often uses lower 32-bit mask
> and higher 32-bit mask, so define the related macro for it, so can let
> code simpler, and avoid various coding styles for them.
>
>  - For lower, some append 'u', some append 'U', and some no 'u' or 'U'.
>
>  - For higher, some append 'ull', some use type cast.
>
>  - For lower but may be used higher bits, append 'ull'.

Is this patch fixing any actual bugs? I think code-style-wise
I prefer what we have at the moment...

-- PMM

--

Chen Gang