[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH 3/7] uri: avoid NULL arguments to strcmp
From: |
Paolo Bonzini |
Subject: |
[Qemu-trivial] [PATCH 3/7] uri: avoid NULL arguments to strcmp |
Date: |
Mon, 26 Jan 2015 12:12:23 +0100 |
Detected by Coverity.
Signed-off-by: Paolo Bonzini <address@hidden>
---
util/uri.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/util/uri.c b/util/uri.c
index 918d235..014d40d 100644
--- a/util/uri.c
+++ b/util/uri.c
@@ -1971,7 +1971,9 @@ uri_resolve_relative (const char *uri, const char * base)
val = g_strdup (uri);
goto done;
}
- if (!strcmp(bas->path, ref->path)) {
+ if (bas->path == ref->path ||
+ (bas->path != NULL && ref->path != NULL &&
+ !strcmp(bas->path, ref->path))) {
val = g_strdup("");
goto done;
}
--
1.8.3.1
- [Qemu-trivial] [PATCH 0/7] Six coverity fixes and a cleanup, Paolo Bonzini, 2015/01/26
- [Qemu-trivial] [PATCH 2/7] cpu-exec: simplify icount code, Paolo Bonzini, 2015/01/26
- [Qemu-trivial] [PATCH 5/7] cutils: refine strtol error handling in parse_debug_env, Paolo Bonzini, 2015/01/26
- [Qemu-trivial] [PATCH 3/7] uri: avoid NULL arguments to strcmp,
Paolo Bonzini <=
- [Qemu-trivial] [PATCH 4/7] qemu-sockets: improve error reporting in unix_listen_opts, Paolo Bonzini, 2015/01/26
- [Qemu-trivial] [PATCH 6/7] aes: remove a dead return statement, Paolo Bonzini, 2015/01/26
- [Qemu-trivial] [PATCH 1/7] cpu-exec: drop dead assignment, Paolo Bonzini, 2015/01/26
- [Qemu-trivial] [PATCH 7/7] migration: do floating-point division, Paolo Bonzini, 2015/01/26