[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struc
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other |
|
Date: |
Mon, 26 Jan 2015 15:01:52 +0000 |
On 26 January 2015 at 14:59, Chen Gang S <address@hidden> wrote:
> On 1/26/15 06:10, Peter Maydell wrote:
>> I would just like the commit message to be clear about the
>> scope of the work the patch covers. If the patch is just "Fix
>> mismatched lock/unlock calls in IPC struct conversion functions"
>> then that's fine, but the commit message should say that. At the
>> moment the commit message is very vague.
>>
>
> OK, thanks.
>
> I am not quite familiar with this file, so I describe the modification
> by function name, e.g. lock_user_struct() and unlick_user_struct() in
> the patch subject.
In a big file I think it's often more useful to describe the
functions which are being changed. My suggested subject would be:
"Fix mismatched lock/unlock calls in IPC struct conversion functions"
Riku can decide if he wants a v2 or will just fix it up as he
applies it to his linux-user tree.
-- PMM
- [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/25
- Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Peter Maydell, 2015/01/25
- Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/25
- Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Peter Maydell, 2015/01/25
- Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/26
- Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other,
Peter Maydell <=
- Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/26
- Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Riku Voipio, 2015/01/28
- Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/28
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Peter Maydell, 2015/01/28
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] linux-user/syscall.c: Let all lock_user_struct() and unlock_user_struct() paired with each other, Chen Gang S, 2015/01/28