qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v2] linux-user/syscall.c: Need call unlock_use


From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH v2] linux-user/syscall.c: Need call unlock_user() before go to failure return in default case
Date: Tue, 27 Jan 2015 20:24:27 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0

25.01.2015 03:00, Chen Gang S wrote:
> In abi_long do_ioctl_dm(), after calls lock_user(), it does not call
> unlock_user() before go to failure return in default case.

Applied to -trivial, with the following description (modified just slightly,
I tried to keep original wording as much as possible):

    linux-user/syscall.c: do_ioctl_dm: Need to call unlock_user() before going 
to failure return in default case

    In abi_long do_ioctl_dm(), after lock_user() call, the code does
    not call unlock_user() before going to failure return in default case.

Thank you!

/mjt

> Signed-off-by: Chen Gang <address@hidden>
> ---
>  linux-user/syscall.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a427f7a..ec9e4fc 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -3566,6 +3566,7 @@ static abi_long do_ioctl_dm(const IOCTLEntry *ie, 
> uint8_t *buf_temp, int fd,
>      }
>      default:
>          ret = -TARGET_EINVAL;
> +        unlock_user(argptr, guest_data, 0);
>          goto out;
>      }
>      unlock_user(argptr, guest_data, 0);
> @@ -3685,6 +3686,7 @@ static abi_long do_ioctl_dm(const IOCTLEntry *ie, 
> uint8_t *buf_temp, int fd,
>              break;
>          }
>          default:
> +            unlock_user(argptr, guest_data, 0);
>              ret = -TARGET_EINVAL;
>              goto out;
>          }
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]