qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after c


From: Markus Armbruster
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad
Date: Tue, 10 Feb 2015 13:03:47 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Since maintainers haven't picked it up: could this go in via -trivial?

Peter Crosthwaite <address@hidden> writes:

> On Wed, Jan 21, 2015 at 5:18 AM, Markus Armbruster <address@hidden> wrote:
>> The "fall through" added by the commit is clearly intentional.  Mark
>> it so.  Hushes up Coverity.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Reviewed-by: Peter Crosthwaite <address@hidden>
>
>> ---
>>  hw/net/xilinx_ethlite.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c
>> index 9536f64..ad6b553 100644
>> --- a/hw/net/xilinx_ethlite.c
>> +++ b/hw/net/xilinx_ethlite.c
>> @@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr,
>>              if (!(value & CTRL_S)) {
>>                  qemu_flush_queued_packets(qemu_get_queue(s->nic));
>>              }
>> +            /* fall through */
>>          case R_TX_LEN0:
>>          case R_TX_LEN1:
>>          case R_TX_GIE0:
>> --
>> 1.9.3
>>
>>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]