qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH microblaze v1 5/6] mb: cpu: Delete EXCP_NMI


From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH microblaze v1 5/6] mb: cpu: Delete EXCP_NMI
Date: Mon, 27 Apr 2015 16:41:13 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0

27.04.2015 12:28, Edgar E. Iglesias wrote:
> On Sun, Apr 26, 2015 at 12:10:23PM -0700, Peter Crosthwaite wrote:
>> This define is unused. Remove.
>>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
> 
> Hi,
> 
> Any reason not to shift down the numbering?
> 
> Otherwise the whole series looks good to me.

What does this mean, "looks good", is it your R-b? :)

>> @@ -36,7 +36,6 @@ typedef struct CPUMBState CPUMBState;
>>  
>>  #define ELF_MACHINE EM_MICROBLAZE
>>  
>> -#define EXCP_NMI        1
>>  #define EXCP_MMU        2
>>  #define EXCP_IRQ        3
>>  #define EXCP_BREAK      4

I can renumber this on commit just fine, there's no need
to resend whole thing, is it okay with you Peter?

Thanks,

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]